Webp image loader and EXT_texture_webp#2722
Merged
riccardobl merged 7 commits intojMonkeyEngine:masterfrom Apr 26, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new image loaders based on the STB library and WebP decoder, aiming to replace older, platform-specific loaders like HDRLoader, TGALoader, and AWTLoader. It also adds support for the EXT_texture_webp glTF extension. My review highlights a critical thread-safety issue in StbImageLoader due to shared state, a potential loss of precision when loading 32-bit float HDR images, and a recommendation to improve memory efficiency by avoiding intermediate heap allocations during stream reading. Additionally, I suggest refining the exception handling in WebpImageLoader to avoid catching generic exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Webp image loader for every platform (was only limited to android before this PR) using a java port of the rust crate image-webp's decoder.
Built on top of #2718
The PR also implements the
EXT_texture_webpfor the gltf loader.Closes #2616